Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of Array.at #430

Closed
stnor opened this issue Jan 23, 2024 · 1 comment
Closed

Remove usage of Array.at #430

stnor opened this issue Jan 23, 2024 · 1 comment
Labels
Resolution: Duplicate This issue or pull request already exists Resolution: Won't Fix A real bug or issue, but the issue is not impactful enough to spend time on.

Comments

@stnor
Copy link

stnor commented Jan 23, 2024

Bug Report

Array.at isn't available in some browsers, like iOS 12.5

Proposed changes

Replace the two occurrences of
values.at(-1)with values[values.length-1]
to make this library work fine in those browsers.
@stnor stnor added Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels Jan 23, 2024
@RebeccaStevens RebeccaStevens added Resolution: Won't Fix A real bug or issue, but the issue is not impactful enough to spend time on. Resolution: Duplicate This issue or pull request already exists and removed Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels Jan 23, 2024
@RebeccaStevens
Copy link
Owner

Duplicate of #411

@RebeccaStevens RebeccaStevens marked this as a duplicate of #411 Jan 23, 2024
@RebeccaStevens RebeccaStevens closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Duplicate This issue or pull request already exists Resolution: Won't Fix A real bug or issue, but the issue is not impactful enough to spend time on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stnor @RebeccaStevens