Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding clientProvidedName to Rabbit's ConnectionFactory #52

Closed
hulvei3 opened this issue Apr 29, 2019 · 5 comments
Closed

Support adding clientProvidedName to Rabbit's ConnectionFactory #52

hulvei3 opened this issue Apr 29, 2019 · 5 comments
Projects

Comments

@hulvei3
Copy link

hulvei3 commented Apr 29, 2019

For debugging purposes, it would be nice to have the option to "label" the connections created with Rebus. This is supported through rabbitmq client and could be defaulted to the assembly or namespace - or not.

This properly fits directly into the ConnectionManager unless there's a better way of grouping the properties to rabbit

@hulvei3 hulvei3 changed the title Support adding clientProvidedName to RabbitConnectionFactory Support adding clientProvidedName to Rabbit's ConnectionFactory Apr 29, 2019
@mookid8000 mookid8000 reopened this Apr 29, 2019
@mookid8000
Copy link
Member

Sorry for closing... I thought I had the answer, but I was too quick there.

That would indeed be a nice feature 😄

Defaulting to the entry assembly or something similar would definitely be neat. It could then be customized in the same way as client properties are configured (did you know that that was possible?)

@hulvei3
Copy link
Author

hulvei3 commented May 1, 2019

Yes, that would be a natural place to put it. Let me see if I cannot find time to make a PR within the next days..

@jarikp
Copy link
Contributor

jarikp commented Aug 26, 2019

hi @hulvei3 ,
you can achieve that by decorating the connection factory, as it's shown in my PR.
/Jarik

@mookid8000 mookid8000 added this to Assess in Rebus via automation Mar 23, 2020
@mookid8000
Copy link
Member

Note to future self or someone else: When RabbitMq.Client 6 is released, this can be easily solved. 🙂

@hulvei3
Copy link
Author

hulvei3 commented Mar 23, 2020

Actually, I solved this by using .ClientConnectionName(..) on the RMQ configurer object. Not sure why I missed that a year ago. Maybe it was added afterwards.

Will anyway close this issue.

@hulvei3 hulvei3 closed this as completed Mar 23, 2020
Rebus automation moved this from Assess to Done Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Rebus
  
Done
Development

No branches or pull requests

3 participants