dtNode* dtNodePool::getNode(dtPolyRef id, unsigned char state) hardlock if Query is initated with too small of maxNodes

[xeropresence]

We get stuck in this loop

while (i != DT_NULL_IDX)
{
    if (m_nodes[i].id == id && m_nodes[i].state == state)
        return &m_nodes[i];
    i = m_next[i];
}

In the case I can reproduce, there will be a node with the id we are looking for but the state does not match. the variable I jumps back and forth between two values and never reaches the breakout value.

[xeropresence]

I use a maxnode value of 0xFFFFFF by default...to get this one area to return a partial result and error out I have to use a crazy number of 0xFFFFFFF

[xeropresence]

Issue happens when calling

dtStatus dtNavMeshQuery::findPath(dtPolyRef startRef, dtPolyRef endRef,
const float* startPos, const float* endPos,
const dtQueryFilter* filter,
dtPolyRef* path, int* pathCount, const int maxPath) const

When a really high query result is used the function runs to completion but a empty path is returned.

If I change

dtNode* neighbourNode = m_nodePool->getNode(neighbourRef, crossSide);

to

dtNode* neighbourNode = m_nodePool->getNode(neighbourRef, 0);

A proper partial path is returned for both my normal and xlarge maxnnode.