Allow stats polling from docker containers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're running some application in docker images now, we need to execute the stat commands in a container instead of running them directly on the host machine.
vutoff
approved these changes
Mar 1, 2019
avlazarov
force-pushed
the
docker-containers-usage
branch
from
8b0d6f3
to
4147fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We had an issue with the monolith after switching to docker containers as the stat commands now need to be executed against the container.
Implementation
We're now passing an ENV variable so that we know which target container to run the stats commands against. We still support the non-container version.