Replies: 2 comments 13 replies
-
Further observations: Charts that use generateCategoricalChart:
Charts that do not:
Thus we could:
Either way forward, we should add tests. |
Beta Was this translation helpful? Give feedback.
-
So I spent some time with the library and I'm thinking about few ways forward. It's a bit of a wall of text but TL;DR is: push model (components push props to shared configuration) or pull model (components read shared state) or something else? First some observationA. Recharts has a truly unique API for custom components where instead of passing in Now my opinion
My thought process
5a. Embrace the "marker elements idea" completely:
5b. Or forget the markers:
5c. Some completely different approach?
If you made it this far, thank you for your attention. And what do you think? (5a) or (5b) or (5c)? |
Beta Was this translation helpful? Give feedback.
-
Recharts uses a HUGE generator function called
generateCategoricalChart
to generate most charts. This function is a lot of things:This file needs quite the lift in order to refactor and retain current functionality. How will we refactor? What has potential to break (everything?)? What do we know? What do we have no clue about? Which components do NOT rely on
generateCategoricalChart
?This and more are things that we need to know in order to make important decisions about the future of this library.
Use this as a thread to discuss
Adding @nikolasrieble @akamfoad @Yilun-Sun
Some thoughts in this thread
Beta Was this translation helpful? Give feedback.
All reactions