Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None of the jsfiddle samples from the website are working #2375

Closed
1 task done
arunrmatwork opened this issue Jan 6, 2021 · 3 comments
Closed
1 task done

None of the jsfiddle samples from the website are working #2375

arunrmatwork opened this issue Jan 6, 2021 · 3 comments

Comments

@arunrmatwork
Copy link

arunrmatwork commented Jan 6, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://jsfiddle.net/alidingling/rnywhbu8/

Steps to reproduce

Go to https://recharts.org/en-US/examples/CustomShapeBarChart
click on the jsfiddle link which will take you to https://jsfiddle.net/alidingling/rnywhbu8/

What is expected?

on "run" the page should show the chart

What is actually happening?

the chart is not rendered.

Environment Info
Recharts v2.0.0
React latest
System Mac
Browser chrome, safari
@dillonreedy
Copy link
Contributor

The latest version 2 release has caused this to happen. Fixes are currently in progress.

If you use CodeSandbox instead you can rollback to the beta versions or v1.8.5

@avindra
Copy link
Contributor

avindra commented Jan 12, 2021

There is a problem with jsfiddle's compilation pipeline. I see this error in console:

Uncaught TypeError: _ is undefined
    render Text.tsx:207
    React 55
    <anonymous> (index):50
    run babel.js:60802
    check babel.js:60868
    loadScripts babel.js:60909
    runScripts babel.js:60936
    transformScriptTags babel.js:324
Text.tsx:207:6
    render Text.tsx:207
    React 55
    <anonymous> Inline Babel script:58
    run babel.js:60802
    check babel.js:60868
    loadScripts babel.js:60909
    runScripts babel.js:60936
    transformScriptTags babel.js:324

I moved your example to codesandbox and it works there with 2.0.2. Codesandbox makes it very easy to add dependencies in tests, and more importantly seems to be working.

@avindra
Copy link
Contributor

avindra commented Jan 12, 2021

@arunrmatwork just noticed this affected core examples, I created a new issue against the site repo:

recharts/recharts.org#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants