Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Customized component #4551

Open
PavelVanecek opened this issue May 19, 2024 · 1 comment
Open

Remove Customized component #4551

PavelVanecek opened this issue May 19, 2024 · 1 comment
Labels
3.0 Issues we need fixed before releasing 3.0 breaking change Use this label to indicate a breaking change in the Recharts API

Comments

@PavelVanecek
Copy link
Collaborator

PavelVanecek commented May 19, 2024 •
edited

Following up from #4437:

Delete Customized component without replacement.

Once we fix #2788, one of the two reasons for its existence will disappear! For the second one there is #4552
@PavelVanecek PavelVanecek added breaking change Use this label to indicate a breaking change in the Recharts API 3.0 Issues we need fixed before releasing 3.0 labels May 19, 2024
@PavelVanecek PavelVanecek mentioned this issue May 19, 2024
Open
@ckifer
Copy link
Member

ckifer commented May 19, 2024 •
edited

Removing customized breaks this https://github.com/recharts/recharts/blob/3.x/test/util/context.tsx#L24
Which breaks a lot of tests :/

I think we may have to fix #2788 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 Issues we need fixed before releasing 3.0 breaking change Use this label to indicate a breaking change in the Recharts API
Projects
Recharts 3.0
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PavelVanecek @ckifer