Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with requests > 2.4.1 due to new json param #31

Closed
guykisel opened this issue Dec 5, 2014 · 3 comments
Closed

Incompatible with requests > 2.4.1 due to new json param #31

guykisel opened this issue Dec 5, 2014 · 3 comments
Labels

Comments

@guykisel
Copy link

guykisel commented Dec 5, 2014

This PR seems to have broken compatibility - https://github.com/kennethreitz/requests/pull/2258

  File "/Users/gkisel/.virtualenvs/my_venv/lib/python2.7/site-packages/requests/api.py", line 99, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "/Users/gkisel/.virtualenvs/my_venv/lib/python2.7/site-packages/requests/api.py", line 49, in request
    response = session.request(method=method, url=url, **kwargs)
TypeError: request() got an unexpected keyword argument 'json'
@reclosedev
Copy link
Collaborator

Thanks! Fixed and published v0.4.7 on PyPI.

@guykisel
Copy link
Author

guykisel commented Dec 6, 2014

Thanks for the quick fix!

@JWCook
Copy link
Member

JWCook commented Sep 7, 2021

For reference: See also #102

@JWCook JWCook added the bug label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants