Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not install "tests" package #222

Merged
merged 1 commit into from Apr 10, 2021
Merged

Do not install "tests" package #222

merged 1 commit into from Apr 10, 2021

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Apr 10, 2021

Installing tests package in global scope is just wrong.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.368% when pulling 430424b on mgorny:no-install-tests into a9dd85a on reclosedev:master.

@JWCook JWCook merged commit f6a8f32 into requests-cache:master Apr 10, 2021
@mgorny
Copy link
Contributor Author

mgorny commented Apr 14, 2021

Hmm, I see that the tests disappeared from sdist as a result of this change. Do you wish me to submit a followup fix for that or do you prefer it to stay that way?

@JWCook
Copy link
Member

JWCook commented Apr 14, 2021

That's likely my fault. I'll add those back. Thanks for the heads up!

@JWCook
Copy link
Member

JWCook commented Apr 14, 2021

@mgorny Fixed in 0.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgorny @coveralls @JWCook