Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic fcast support #1084

Merged
merged 2 commits into from May 9, 2024
Merged

Conversation

CranberrySoup
Copy link
Contributor

This supports starting videos using fcast using the long press menu.

Things to improve in the future:

  • Proper cast UI with play, pause and seek
  • Subtitle support
  • CloudStream acting as a proper fcast receiver

These should not be too hard to implement given the now existing framework. Subtitle support is probably the easiest to implement in case anyone else wants to contribute.

Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@fire-light42 fire-light42 merged commit ee4d1de into recloudstream:master May 9, 2024
2 checks passed
@oathzed
Copy link

oathzed commented May 9, 2024

This supports starting videos using fcast using the long press menu.

Things to improve in the future:

  • Proper cast UI with play, pause and seek
  • Subtitle support
  • CloudStream acting as a proper fcast receiver

These should not be too hard to implement given the now existing framework. Subtitle support is probably the easiest to implement in case anyone else wants to contribute.

Well done on this.

It would be nicer UX though if the receiver showed up under your cast button like all the other DNLA receivers. So it's not under a long press. Also if possible if a source doesn't work, then it will try another one till it works, just like how the internal player works.

@fire-light42
Copy link
Collaborator

It would be nicer UX though if the receiver showed up under your cast button like all the other DNLA receivers. So it's not under a long press. Also if possible if a source doesn't work, then it will try another one till it works, just like how the internal player works.

Add basic fcast support

@oathzed
Copy link

oathzed commented May 9, 2024

It would be nicer UX though if the receiver showed up under your cast button like all the other DNLA receivers. So it's not under a long press. Also if possible if a source doesn't work, then it will try another one till it works, just like how the internal player works.

Add basic fcast support

I understand, I'm just explaining how it would be better eventually when it gets improved Incase this wasn't how y'all were gonna do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants