-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitle icons not parsing #1109
Comments
Can you elaborate, where this screenshot appears? |
Sorry I should have checked first I suppose this could potentially also be a provider issue. It was not related to update. It happens on stable release as well. I just opened a random series from the sorastream home page and it happened. |
It doesn't happen when searching online subtitles only the auto subtitles though. |
So it's for sure one of sub providers of SS |
I think this has to do with opensubtitles, if you search subtitles on opensubtitles.com you get icons in there also like the fa-check which means "Subtitles from trusted source" I think CloudStream needs to handle parsing this HTML properly. Probably stripping the check marks but could probably replacing the hearing impaired HTML icon with the icon used in CloudStream within subtitles search. Looks like the same type of icon would also happen with SubDL and maybe addic7ed as well but I'm unsure if those even supports auto subtitles. Also on another note, SubDL seems unreliable a bit, if you open subtitles on SubDL it shows a lot more then when you Search Online Subtitles from within CloudStream, it seems to omit any with Hearing Impaired at all and others (maybe omitting HI is just a coincidence but it seems only about 5% that actually exist in SubDL properly show up when searching in CloudStream) |
Wait I'm just now learning how subtitles even work. This potentially isn't even a CS issue but rather extension issue. I'm unsure. If it is I apologize. |
Opensubtitles api provider uses api only, no parsing at all SubDL & OpenSubtitles load only on "load online subtitles" For SubDL issue, i will review. They changes the api a lot as they are always working on it currently |
You are right, SubDL api has an filtering issue |
Steps to reproduce
Find a video with Hearing Impaired default subtitles
Expected behavior
Icon to display properly
Actual behavior
Cloudstream version and commit hash
4.3.2 dff5602
Android version
Android 14
Logcat
No response
Other details
I noticed this after updating to dff5602 and logging into SubDL account. I am not sure if it happened before but I assumed it had something to do with that.
Acknowledgements
The text was updated successfully, but these errors were encountered: