Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub account #128

Closed
wants to merge 52 commits into from
Closed

GitHub account #128

wants to merge 52 commits into from

Conversation

antonydp
Copy link
Contributor

No description provided.

@Blatzar
Copy link
Contributor

Blatzar commented Sep 30, 2022

Looks good, @LagradOst ?

Is there anything missing or incomplete? I can help if there's anything 🙏

@antonydp
Copy link
Contributor Author

The main functions (backupGithub & restorePromptGithub) are working for me,
we now need to decide if it's best to add a dedicated "backup data on cloud" button or to make it do that automatically or both.
Also before merging I think someone else should compile it and try all the features to see if it's actually working fine.

@venkat2305
Copy link

Can you explain how it works in layman terms?

@C10udburst
Copy link
Member

hm. it still doesnt seem to properly push the settings to the gist

@Blatzar
Copy link
Contributor

Blatzar commented Nov 4, 2022

To make the home page refresh you can do the following:
In the HomeFragment companion object:

val reloadStoredDataEvent = Event<Unit>()

in the onstop and onresume in homefragment.kt inlude the new method like the following

    override fun onResume() {
        super.onResume()
        reloadStored()
        afterPluginsLoadedEvent += ::firstLoadHomePage
        mainPluginsLoadedEvent += ::firstLoadHomePage
        reloadStoredDataEvent += ::reloadStoredEvent
    }

    override fun onStop() {
        afterPluginsLoadedEvent -= ::firstLoadHomePage
        mainPluginsLoadedEvent -= ::firstLoadHomePage
        reloadStoredDataEvent -= ::reloadStoredEvent
        super.onStop()
    }

    private fun reloadStoredEvent(input: Unit) {
        reloadStored()
    }

Now you can call HomeFragment.reloadStoredDataEvent.invoke(Unit) from wherever you want and it'll reload all the local data @antonydp

Copy link
Member

@C10udburst C10udburst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly for me

@LagradOst
Copy link
Contributor

LagradOst commented Dec 3, 2022

I tested this now on a fresh dummy account on a fresh cs3 install and got some things to say.

  1. the toast when exiting the app saying "saved data" is super annoying, it is better to have a toast if it fails
  2. It did not work for me and instead created many gist with the same name?????
    image
  3. The account got fucked because it looked sus af to have an 20min old acc creating many gists. please add a note that that might happend if ppl create new accounts
    image

I can take a look at the code too, but these are kinda important impo

@Blatzar Blatzar mentioned this pull request Mar 16, 2023
3 tasks
@antonydp antonydp closed this by deleting the head repository Mar 21, 2023
@venkat2305
Copy link

closed but why?

@RokeJulianLockhart

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants