Add zh_TW

[jhihyulin]

Add Traditional Chinese (Taiwan)

[C10udburst]

Fails to build: values-zh-TW: Error: Invalid resource directory name

[Sdarfeesh]

It seems like the Traditional Chinese translation cannot load, could you fix that?

-2022-11-12-11-33-50.mp4

[jhihyulin]

I don't know how to fix this bug, but now I can go into the application and skip the language setting and it will display normally, so the problem should be in the language code in app\src\main\java\com\lagradost\cloudstream3\ui\settings\SettingsGeneral.kt line 79, or in the other settings of the language setting file?

[Sdarfeesh]

I don't know how to fix this bug, but now I can go into the application and skip the language setting and it will display normally, so the problem should be in the language code in app\src\main\java\com\lagradost\cloudstream3\ui\settings\SettingsGeneral.kt line 79, or in the other settings of the language setting file?

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 3fc63a2

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Chinese Traditional", "zh-Hant-TW"),

The language code should be same as values-* !!!

[jhihyulin]

I don't know how to fix this bug, but now I can go into the application and skip the language setting and it will display normally, so the problem should be in the language code in app\src\main\java\com\lagradost\cloudstream3\ui\settings\SettingsGeneral.kt line 79, or in the other settings of the language setting file?

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 3fc63a2

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Chinese Traditional", "zh-Hant-TW"),

The language code should be same as values-* !!!

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 0a8cb1d

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Traditional Chinese", "zh-rTW"),

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 809693e

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Traditional Chinese", "zh-TW"),

Tried it, doesn't work

[Sdarfeesh]

I don't know how to fix this bug, but now I can go into the application and skip the language setting and it will display normally, so the problem should be in the language code in app\src\main\java\com\lagradost\cloudstream3\ui\settings\SettingsGeneral.kt line 79, or in the other settings of the language setting file?

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 3fc63a2

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Chinese Traditional", "zh-Hant-TW"),

The language code should be same as values-* !!!

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 0a8cb1d

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Traditional Chinese", "zh-rTW"),

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 809693e

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Traditional Chinese", "zh-TW"),

Tried it, doesn't work

I found the problem, because ISO 639-1 codes only have zh code for Chinese, so it's not possible to add another Chinese language

[Sdarfeesh]

I don't know how to fix this bug, but now I can go into the application and skip the language setting and it will display normally, so the problem should be in the language code in app\src\main\java\com\lagradost\cloudstream3\ui\settings\SettingsGeneral.kt line 79, or in the other settings of the language setting file?

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 3fc63a2

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Chinese Traditional", "zh-Hant-TW"),

The language code should be same as values-* !!!

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 0a8cb1d

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Traditional Chinese", "zh-rTW"),

cloudstream/app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt

Line 79 in 809693e

Triple("\uD83C\uDDF9\uD83C\uDDFC", "Traditional Chinese", "zh-TW"),

Tried it, doesn't work

You can try to use a code of ISO 639-1 codes that isn't used
(For example, tw)

[jhihyulin]

I don't think using other code is the best option, which may cause the language to not be set automatically.

BTW, tw is already used in the ISO 639-1

[Blatzar]

Java Locale has Traditional Chinese but that cannot be instantiated given only a language code.

I think creating an exception hashmap and just manually mapping the locales there would be the least messy solution:

Right below appLanguages:

/**
 * Not all languages can be fetched from locale with a code.
 * This map allows sidestepping the default Locale(languageCode)
 * when setting the app language.
 **/
val appLanguageExceptions = hashMapOf(
    "zh-Hant-TW" to Locale.TRADITIONAL_CHINESE
)

and in https://github.com/recloudstream/cloudstream/blob/master/app/src/main/java/com/lagradost/cloudstream3/CommonActivity.kt#L113 you can add the exception like this:

val locale = appLanguageExceptions[languageCode] ?: Locale(languageCode)

[jhihyulin]

The language can now be switched normally, but there is still a problem with the part where the language selection is displayed.

[Blatzar]

The language can now be switched normally, but there is still a problem with the part where the language selection is displayed.

What do you mean?

[jhihyulin]

The language can now be switched normally, but there is still a problem with the part where the language selection is displayed.

What do you mean?

Like this
Select Traditional Chinese, the language of the interface is also Traditional Chinese, but the language menu shows that Simplified Chinese is selected.

Record_2022-11-13-17-27-47.mp4

[Blatzar]

Weird, I'll get to investigating soon

[Blatzar]

Sorry for the wait 😔