-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use user setting for seeking on Android TV #342
Conversation
@TerHano I don't understand much (on coding), but looking at the changes. it looks same. |
Sorry about that, I had done some edits prior to checking in and it looks like the minus was deleted. Should be fixed now. |
When I was designing TV UI I wanted to have two ways of seeking.
I feel that my design is very intuitive because it gives you more control when seeking. You could add second "TV seeking time" setting, so users can tweak that and use it here, but using only one value is a bad idea. |
# Conflicts: # app/src/main/res/values-es/strings.xml
I agree that having two settings would be nice. I made the change and added the settings, let me know if it's what you had in mind. |
I would remove semicolons, because you don't need them in kotlin and it looks weird when only your lines have them, but overall looks good to me, great work :) |
LGTM, ready to merge? |
No description provided.