Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Linkbox #390

Merged
merged 1 commit into from
Feb 24, 2023
Merged

fixed Linkbox #390

merged 1 commit into from
Feb 24, 2023

Conversation

hexated
Copy link
Contributor

@hexated hexated commented Feb 24, 2023

No description provided.

Copy link
Contributor

@Blatzar Blatzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙏
Will merge later today, left some comments if you feel like improving it

link.url,
url,
getQualityFromName(link.resolution)
val id = Regex("""(?:/f/|/file/|\?id=)(\w+)""").find(url)?.groupValues?.get(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to have an example string test for more complex regexes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still work?

getQualityFromName(link.resolution)
val id = Regex("""(?:/f/|/file/|\?id=)(\w+)""").find(url)?.groupValues?.get(1)
app.get("$mainUrl/api/file/detail?itemId=$id", referer = url)
.parsedSafe<Responses>()?.data?.itemInfo?.resolutionList?.map { link ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not that important it is better to use forEach here 😔

@Blatzar Blatzar merged commit f722785 into recloudstream:master Feb 24, 2023
@hexated hexated deleted the extractor branch May 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants