Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS3IPlayer: fix buffer lost when seeked to backward #448

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

Sofie99
Copy link
Contributor

@Sofie99 Sofie99 commented Apr 9, 2023

cloudstream-debug-2023-04-09-20-50-02_UIh0HTRz.mp4

@LagradOst
Copy link
Contributor

uhhh, uniform back and forwards buffer, that is like a lot of waste. I would hardcode it at 30ish sec or half of regular and you often watch movies/tvseries with minimal timeskipping backwards. there is already a lot of Out Of Memory errors, and this will just cause a lot more if we just double the buffer size like this. good pr tho

@Sofie99
Copy link
Contributor Author

Sofie99 commented Apr 9, 2023

uhhh, uniform back and forwards buffer, that is like a lot of waste. I would hardcode it at 30ish sec or half of regular and you often watch movies/tvseries with minimal timeskipping backwards. there is already a lot of Out Of Memory errors, and this will just cause a lot more if we just double the buffer size like this. good pr tho

ah yeah.. i don't really know how much buffer to put in
thx..

@asl97
Copy link

asl97 commented Apr 9, 2023

uhhh, uniform back and forwards buffer, that is like a lot of waste. I would hardcode it at 30ish sec or half of regular and you often watch movies/tvseries with minimal timeskipping backwards. there is already a lot of Out Of Memory errors, and this will just cause a lot more if we just double the buffer size like this. good pr tho

PIP seek by 30 sec, maybe PIP seek should be reduce or a bigger buffer than 30 sec.

val actions: ArrayList<RemoteAction> = ArrayList()
actions.add(
getRemoteAction(
activity,
R.drawable.go_back_30,
R.string.go_back_30,
CSPlayerEvent.SeekBack
)
)

@Sofie99
Copy link
Contributor Author

Sofie99 commented Apr 11, 2023

@LagradOst changed it with 30sec

ready to merge

@LagradOst LagradOst merged commit b356ad9 into recloudstream:master Apr 11, 2023
1 check passed
@Sofie99 Sofie99 deleted the exoplayer-seek branch April 23, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants