Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to viewbindings #507

Merged
merged 31 commits into from
Jul 30, 2023
Merged

Migration to viewbindings #507

merged 31 commits into from
Jul 30, 2023

Conversation

LagradOst
Copy link
Contributor

No description provided.

Amrullah609

This comment was marked as off-topic.

Sign in to view

@IndusAryan
Copy link
Contributor

I guess you also started working on Media3 Migration as exoplayer is deprecated now.

@LagradOst
Copy link
Contributor Author

LagradOst commented Jul 16, 2023 •
edited
Loading

  • Migrate to viewbindings
  • Update downloadbutton UI
  • Minor fixes

Not done synthetic. All beside (HomeParentItemAdapterPreview) inherits from player. Might need to be migrated to its own view?
HomeParentItemAdapterPreview need to be refactored af, but they dont share the top view at all so hard to bind
(R.layout.fragment_home_head != R.layout.fragment_home_head_tv)

  • ResultFragmentPhone
  • HomeParentItemAdapterPreview
  • AbstractPlayerFragment
  • FullScreenPlayer
  • ResultFragment
  • GeneratorPlayer
  • ResultFragmentTv
  • ResultTrailerPlayer

@LagradOst LagradOst marked this pull request as ready for review July 16, 2023 00:38
@LagradOst
Copy link
Contributor Author

I decided that results pages should be split up between tv and phone, this shoud not impact it as resultviewmodel should handle all the hard stuff. but this frees up tv from having to load the trailer. the trailer inheratance chain was also changed

@LagradOst
Copy link
Contributor Author

This is ready to be merged into main 👍

@LagradOst LagradOst merged commit 4b4e006 into master Jul 30, 2023
1 of 2 checks passed
@LagradOst LagradOst mentioned this pull request Jul 31, 2023
Closed
@fire-light42 fire-light42 deleted the viewbindings branch December 10, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amrullah609 Amrullah609 Amrullah609 left review comments

@C10udburst C10udburst Awaiting requested review from C10udburst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LagradOst @IndusAryan @Amrullah609