Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic backups #592

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Automatic backups #592

merged 2 commits into from
Oct 10, 2023

Conversation

self-similarity
Copy link
Contributor

Based on SubscriptionWorkManager.
Refactored some backup code to handle context better.

Resolves #591

@ghost
Copy link

ghost commented Sep 7, 2023

I really hope this will find its way to the app, it will be a game changer.

Thank you a lot.

@ghost
Copy link

ghost commented Sep 7, 2023

From my basic understanding, I did not see any changes to manifest file to give the permission for handling files or folders, so is it gonna save it automatically in the Download folder as usual? And is it gonna delete the old files?

I'm asking because the build has failed so there is no apk to test.

@C10udburst
Copy link
Member

I'm asking because the build has failed so there is no apk to test.

build failed because we are being held hostage by JitPack 😭

@ghost
Copy link

ghost commented Sep 9, 2023

Hi again, thank you so much for your work and effort.

I'm here because I tested the app, and as I expected there is no option to specify the folder for the backup, and this will make it a little harder to track and sync, I hope in the future you will implement an option to choose a folder that the app will store its backup in it and also to delete older backups, that will make the app literally perfect.

@IndusAryan
Copy link
Contributor

there is a fixed folder for backups that is downloads

@ghost
Copy link

ghost commented Sep 9, 2023

there is a fixed folder for backups that is downloads

The problem is that the download folder is always active and cannot be used for the backups of CloudStream to sync them, a dedicated folder that we can choose for this specific reason will be very nice, and also the deletion of older files, otherwise the folder will be full of backups we will never use.

@Blatzar
Copy link
Contributor

Blatzar commented Sep 9, 2023

There is no fixed folder, all backups are tied to whatever your video downloading path is (which is changeable). While it is not that clean it leaves room for user options. Ideally it would be in a backup folder in the download path.

@ghost
Copy link

ghost commented Sep 9, 2023

There is no fixed folder, all backups are tied to whatever your video downloading path is (which is changeable). While it is not that clean it leaves room for user options. Ideally it would be in a backup folder in the download path.

Yes, it should be at least in a folder in the download path, although making the option to choose would be the best, and we shouldn't forget deleting older backups, and this should be easier when specifying a dedicated folder, so the process will be deleting everything in that folder then creating a new backup file.

@LagradOst LagradOst merged commit 91b1952 into recloudstream:master Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Backup
5 participants