Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library on TV #663

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Library on TV #663

merged 7 commits into from
Oct 10, 2023

Conversation

KingLucius
Copy link
Contributor

@KingLucius KingLucius commented Oct 7, 2023

that's a draft as I need some help from you guys with the issues below:

Implemented:

  • Library appears on Nav menu.
  • Sort button in the AppBar.
  • Next Focus implementation

Issues:

  • page_recyclerview is focusable, I have tried everything I know without success.
  • search_result_root is focusable in empty tabs.

@LagradOst
Copy link
Contributor

add a testcase for the layout in the testing file

@KingLucius
Copy link
Contributor Author

add a testcase for the layout in the testing file

Done

@KingLucius
Copy link
Contributor Author

KingLucius commented Oct 8, 2023

Now the Tablayout is on top on TV, also viewpager focus issues 90% fixed

@KingLucius KingLucius marked this pull request as ready for review October 10, 2023 09:31
@KingLucius
Copy link
Contributor Author

Everything related to Library on TV layout is ready to be merged, still only the "Sync" part in result TV layout I can't decide how it can fit in this layout.
I think we should merge this till deciding what is the best way to fit the sync in TV layout

At least the users would have the library on TV, still setting the progress via TV

@LagradOst LagradOst merged commit b120a7b into recloudstream:master Oct 10, 2023
2 checks passed
@KingLucius KingLucius deleted the libOnTV branch October 11, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants