Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade androidx.navigation:navigation-fragment-ktx to 2.7.4 #676

Closed
wants to merge 1 commit into from

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Oct 9, 2023

This also required bumping targetSdk to 34

I am not sure if androidx.navigation:navigation-ui-ktx should be bumped as well or not.

Fixes #625

@LagradOst
Copy link
Contributor

are you sure this fixes the issue?

@Luna712
Copy link
Contributor Author

Luna712 commented Oct 9, 2023

are you sure this fixes the issue?

it appears to, I looked at commits, and confirmed one of the issues it mentions is at least similar, double clicking the back button is what breaks the navigation graph, consistently reproducable, doing that after upgrading this does not break it. Whether every cause is that I'm not sure 100% but this does fix that one issue at least.

@Luna712
Copy link
Contributor Author

Luna712 commented Oct 9, 2023

Basically I can't confirm 100%, because I could never figure out the exact circumstances, I did figure out some exact circumstances it breaks now and this prevents that from happening. Whether there is another way it breaks, I'm unsure. @LagradOst

@IndusAryan
Copy link
Contributor

IndusAryan commented Oct 10, 2023

Basically I can't confirm 100%, because I could never figure out the exact circumstances, I did figure out some exact circumstances it breaks now and this prevents that from happening. Whether there is another way it breaks, I'm unsure. @LagradOst

you may want to close this i am opening a new pr, although the nav graph will still break if somebody preses the bottom bavigation bar item when in sub-settings but the app won't crash and graph will reset when back pressed multiple times.

this crash happens because we dont destroy or pop fragments fully when change navigation item when inside any sub setting

@LagradOst
Copy link
Contributor

im already fixing this

@LagradOst LagradOst closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings sometimes unresponsive
3 participants