Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favorites #682

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add favorites #682

merged 4 commits into from
Oct 13, 2023

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Oct 11, 2023 •
edited
Loading

Refs #614

This also hides subscriptions on TV since they can not be used on TV so no reason to show them in library

@Luna712 Luna712 marked this pull request as draft October 11, 2023 18:51
@Luna712 Luna712 marked this pull request as ready for review October 11, 2023 19:17
@Luna712 Luna712 force-pushed the add-favorites branch 2 times, most recently from 09aff17 to 2f9485e Compare October 11, 2023 19:58
@Luna712
Merge branch 'master' of https://github.com/recloudstream/cloudstream …
d45073c 
…into add-favorites
@Luna712
Hide subscriptions and favorites on TV
fb7c969 
They can not be used on TV so no reason to show them in library
@Luna712
Copy link
Contributor Author

Luna712 commented Oct 12, 2023

This adds favorites to the top bar somewhat based on how subscriptions is done. This way you can add things to specific and favorite them separately, so you can keep better track of shows in the library. Since favorites has a different usage than bookmarks also, it isn't added on the homepage, only to the library. For now, it doesn't work on TV as I couldn't find a good layout implementation for it, so I hid both it and subscriptions in the library since neither can be used on TV, there is no reason for it to be there.

Screenshot_20231012_101418_CloudStream Debug
Screenshot_20231012_101433_CloudStream Debug

LagradOst
LagradOst reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@LagradOst LagradOst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, however I have not tested it, and no tv support?

@Luna712
Copy link
Contributor Author

Luna712 commented Oct 12, 2023

code looks fine, however I have not tested it, and no tv support?

@LagradOst

No TV support yet I might do one on a follow-up, I just could not find a proper place for the UI element on TV layout just yet.

@Luna712
Copy link
Contributor Author

Luna712 commented Oct 13, 2023

@LagradOst I was able to do TV support now afterall

@LagradOst LagradOst merged commit 3cb2196 into recloudstream:master Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LagradOst LagradOst LagradOst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luna712 @LagradOst