Use bottom dialogs for synopsis #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice change UI wise, however it does not keep the HTML text styling nor is the function you use used for this. Create a new function in SingleSelectionHelper called smth like showBottomDialogText and make it accept a Spanned as text and title |
Thanks, done (I think) |
Luna712
force-pushed
the
bottom-dialogs
branch
from
89ca0bf
to
b2f6f37
Compare
fire-light42
approved these changes
Oct 25, 2023
|
Needs testing then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only does for phone, not sure if it should for TV also, also only did this because of the TODO, if it is not wanted, this can be closed