feat(ui): add ok button for pin dialog and use isvisible getter #739
Conversation
IndusAryan
changed the title
|
This was intentionally not done, because it messed it up. If you do it, you only need to add it for when you are actually creating a new pin, but the done button in pin keyboard is the ok button, if you do it another way, a lot of additional validation needs added, and this didn't work right, causing it to dismiss when it shouldn't and breaking validation. |
|
Also I am working on a new PR to improve a few things, one thing it does do is add a done button when creating a new PIN, when you aren't creating a new PIN, everything is dynamic, errors if the PIN is wrong, and auto complete when it is right so this isn't needed for always. Other parts of the PR include account creation at startup and a few other things but I can push that separately if you want me to do the done button faster also? |
|
this is just like a hotfix for tv users, and this works well, although i can close if u want |
|
imo what's the need of account creation at start-up bcos profile icon is just on home? |
It's kinda hard to explain exactly what I am doing, but it basically changes the way accounts creation work to make it a lot easier on TV etc... it is fairly hard to get to account creation on TV so doing from startup makes it a lot easier for UX/UI |
|
Can this be closed please? Later tonight or tomorrow I will hopefully have a new PR that redoes the entire account system UI/UX. If it is decided against, I will do a sperate PR that does this a better way and more convenient for TV and Phone users alike. |
No description provided.