Fix some deprecations and other warnings #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace deprecated onBackPressed() * Fixes some AndroidManifest warnings * Use android:dataExtractionRules for Android 12+ * Add tools:ignore for ScopedStorage and QueryAllPackagesPermission * Make VideoDownloadRestartReceiver not exported (fixes " Exported receiver does not require permission") - if this was incorrect I can revert this part * Bump tools:targetApi * Enable android:enableOnBackInvokedCallback for predictive back gestures on Android 13 (if enabled in developer options) and Android 14 (also fixes "OnBackInvokedCallback is not enabled for the application." which is commonly seen in logcat)
|
lol, I was just minutes away from creating similar backpressed upgrade pr |
Blatzar
suggested changes
Nov 2, 2023
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultTrailerPlayer.kt
Outdated
Show resolved
Hide resolved
|
Very nice to see this, maybe we can implement some cool predictive back gestures after this 🙏 |
|
This wont be merged until the bottom color mismatch is fixed |
fire-light42
requested changes
Nov 10, 2023
fire-light42
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exported receiver does not require permission") - if this was incorrect I can revert this part