Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random button functionality broken. #78

Closed
5 tasks done
Akv2021 opened this issue Sep 1, 2022 · 2 comments · Fixed by #136
Closed
5 tasks done

Random button functionality broken. #78

Akv2021 opened this issue Sep 1, 2022 · 2 comments · Fixed by #136
Labels
bug Something isn't working

Comments

@Akv2021
Copy link

Akv2021 commented Sep 1, 2022

Steps to reproduce

  1. Launch cloudstream beta and Random button disappears after homepage is loaded.
  2. Toggling "Show Random button on homepage" does not make any difference.
  3. On filter provider on homepage, select "random" option. It resets provider to "none".

Expected behavior

There is an issue with both the "Show random button on homepage" option (Floating action button on left on homepage) and "Random" option in Provider chooser (Floating action button on right on homescreen which is used to choose provider to show contents from on homepage).
Expected -

  1. Show random button(LHS FAB) - should randomly open view page of a movie/series
  2. Random option (In RHS FAB) - should randomly choose a provider based in category chosen (i.e. movie/series etc)

Both behaviours are working as expected in the last stable release of cloudstream (v 3.0.0)

Actual behavior

  1. Show random button(LHS FAB) - sometimes briefly shows up when app is launched but always disappears after homepage is loaded.
  2. Random option (In RHS FAB) - selects "none" as provider.

Cloudstream version and commit hash

3.1.4 cdf0047

Android version

Android 9

Logcat

NA

Other details

NA

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to pre-release version Latest.
  • If related to a provider, I have checked the site and it works, but not the app.
  • I will fill out all of the requested information in this form.
@Akv2021 Akv2021 added the bug Something isn't working label Sep 1, 2022
@Jacekun
Copy link
Contributor

Jacekun commented Sep 2, 2022

It becomes invisible cause of this line:

home_random?.isVisible = listHomepageItems.isNotEmpty()

and since when a new homepage is loaded, it refreshes the list:

it will always be toggled off.

It'll need to adjust the code hierarchy so that the toggle will only execute after the homepage is loaded from currently loaded plugin provider.

@Jacekun
Copy link
Contributor

Jacekun commented Oct 6, 2022

Upon further inspection, I'm kinda talking my ass off here. Will PR a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants