Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractor: added vidplay and fix few extractors #795

Merged
merged 6 commits into from
Dec 8, 2023
Merged

extractor: added vidplay and fix few extractors #795

merged 6 commits into from
Dec 8, 2023

Conversation

Sofie99
Copy link
Contributor

@Sofie99 Sofie99 commented Dec 4, 2023

No description provided.

@b4byhuey
Copy link
Contributor

b4byhuey commented Dec 5, 2023

Can you fix Dailymotion? or can you conver from aniyomi here

@Sofie99
Copy link
Contributor Author

Sofie99 commented Dec 5, 2023 •
edited

Can you fix Dailymotion? or can you conver from aniyomi here

maybe next pr
fixed

@Sofie99 Sofie99 changed the title extractor: added Vidplay extractor: added vidplay and fix few extractors Dec 5, 2023
@Sofie99
Copy link
Contributor Author

Sofie99 commented Dec 6, 2023 •
edited

nice work Sofie99, but wrong place to post extension. you should post the PR there but maybe fix direct sorastream (if it doesn't work) instead off a separate file https://github.com/hexated/cloudstream-extensions-hexated or you can create your own repository and join the discord to share your repository.

because cloudstream has nothing to do with the extension 🙈

where extension? this is just extractor and i always doing it here..

@b4byhuey
Copy link
Contributor

b4byhuey commented Dec 6, 2023

Can you fix Dailymotion? or can you conver from aniyomi here

maybe next pr fixed

Thank you

fire-light42
fire-light42 requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont want to ddos github for every call to geturl, save it to a local variable even if app.get may be cached it does not hurt to explicitly cache it

app/src/main/java/com/lagradost/cloudstream3/extractors/Vidplay.kt
}

private suspend fun getKeys(): List<String> {
return app.get("https://raw.githubusercontent.com/Claudemirovsky/worstsource-keys/keys/keys.json")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be cached in a local variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key changes every 5 minutes, same with Rabbitstream extracktor for sflix

@Sofie99
Copy link
Contributor Author

Sofie99 commented Dec 7, 2023

We dont want to ddos github for every call to geturl, save it to a local variable even if app.get may be cached it does not hurt to explicitly cache it

not sure thats a good idea. the key is changing every 5 minutes same like rabbitstream for sflix.

@fire-light42
Copy link
Collaborator

Understandable, I can merge this now if you want

@Sofie99
Copy link
Contributor Author

Sofie99 commented Dec 8, 2023

Understandable, I can merge this now if you want

sure 👍

@fire-light42 fire-light42 merged commit 6f3a8c1 into recloudstream:master Dec 8, 2023
2 checks passed
@Sofie99 Sofie99 deleted the vidplay branch December 10, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire-light42 fire-light42 fire-light42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sofie99 @b4byhuey @fire-light42