feat (library tabs): save and restore tab selection #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
|
Very nice catch, I fixed the other issue with sorting by using this. 🥳 Good first pr! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
savedInstanceState is not restoring the tab selection when you open any movie and return to library section. Also, scroll position is not restored (I was not able to add changes to remember scroll position. Someone, pls give it a try).
Steps to reproduce:
Affects:
This fix will affect tab functionality of the library section.
Fix:
libraryviewmodel will save the tab position and will be used to restore the tab position.