Fixing Source List Displaying Empty Items #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blatzar
reviewed
Dec 11, 2023
| normalSafeApiCall { | ||
| // Extra normalSafeApiCall since .toSet() iterates. | ||
| _currentLinks.postValue(currentLinks.toSet()) | ||
| if (it.first?.url?.isNotEmpty() == true) { |
There was a problem hiding this comment.
This does not account for ExtractorUri (local files), in that case it.first would be null
There was a problem hiding this comment.
Okay, I will try other fix methods
|
Perhaps this would be better implemented in mainapi and we can do warnings and filtering there instead without adding complexity to the already complex link loading. Better to fix it at the source, since links are used by other stuff like the downloader, copy links and external players. |
|
This should instead be in RepoLinkGenerator |
This reverts commit 8ba4879.
… feasible to handle it in the RepoLinkGenerator)
|
|
🙏 Nice, this should fix all the empty links |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.