feat (player): optional rotate button in player and setting to enable auto rotate based on video orientation #813
Conversation
|
This is a really good addition, and the code looks nice. However it fucks up a bit with the current code located at So if you want this merged you can keep this behavior however you need to fix the updateOrientation function to not cause any bugs. By pressing lock you lock the current orientation completely otherwise you do sensor landscape/portrait. |
|
@fire-light42 can you share some desc on how updateorientarion and lockorientation is working? when are they triggered? |
|
where can I get the icons? |
Right now when the user enters the player they will be turned into sensor landscape and when pressing the lock button it will lock to the exact orientation that the player is currently in. updateOrientation is called when entering the player along with when you toggle the lock button. So in your case you need to add a bool like IsVerticalOrientation that is set when first loading a video by overriding playerDimensionsLoaded, then calling updateOrientation. updateOrientation should lock the player in the exact orientation the user is currenty in if isLocked otherwise it should use the sensor version of IsVerticalOrientation. Then the button just changes If you want icons then look at https://fonts.google.com/icons
|
|
thank you for explaining in detail. |
ghost
changed the title
|
@fire-light42 changes are done. pls review. |
| ActivityInfo.SCREEN_ORIENTATION_REVERSE_LANDSCAPE | ||
|
|
||
| Configuration.ORIENTATION_SQUARE, Configuration.ORIENTATION_UNDEFINED -> | ||
| dynamicOrientation(activity) |
There was a problem hiding this comment.
This will cause a bug as orientation will still be zero and 0 = SCREEN_ORIENTATION_LANDSCAPE, so this function will be called then it will call activity.requestedOrientation = SCREEN_ORIENTATION_LANDSCAPE right under this
There was a problem hiding this comment.
you have the same problem in the other functons
There was a problem hiding this comment.
This is how it was in lockOrientation -> Configuration.ORIENTATION_SQUARE, Configuration.ORIENTATION_UNDEFINED, Configuration.ORIENTATION_PORTRAIT -> ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE
Is this doing anything? there is no assignment.
Now in function i have added dynamicOrientation in that it will set-> activity.requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE
So what should be the change? should I keep it how it was? how to test this Configuration.ORIENTATION_SQUARE, Configuration.ORIENTATION_UNDEFINED?
There was a problem hiding this comment.
What I mean is that if you read the code
Then it will set activity.requestedOrientation = orientation and orientation = 0 when currentOrientation = Configuration.ORIENTATION_SQUARE, Configuration.ORIENTATION_UNDEFINED so dynamicOrientation wont do anything as it will be overridden 2 lines later
There was a problem hiding this comment.
In this case I think dynamicOrientation should return what orientation it should be and then set orientation = dynamicOrientation(activity) inside the when statments
There was a problem hiding this comment.
@fire-light42 thanks. Pls chk now.
|
@fire-light42 i have fixed the issue you've shared. pls review and let me know if there is any other issue. |
|
What
في الاثنين، ١٨ ديسمبر ٢٠٢٣, ٨:٥٥ ص coxju ***@***.***> كتب:
… @fire-light42 <https://github.com/fire-light42> fixed the issue youve
shared. pls review and let me know there is any other issue.
—
Reply to this email directly, view it on GitHub
<#813 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4ELJC4GYYU3LVMMOPCCVH3YJ7SHDAVCNFSM6AAAAABATKVG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGY2TINZUGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
… auto rotate based on video orientation
ghost
deleted the
setting page:
with rotate enabled:
