Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : show favorite button in bottom dialog #858

Merged
merged 1 commit into from Jan 10, 2024
Merged

feat : show favorite button in bottom dialog #858

merged 1 commit into from Jan 10, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2024

Screenshot:
after adding to favorite
image

after removing from favorite
image

@fire-light42
Copy link
Collaborator

Damn, looks sexy. The code looks fine, and will merge this after testing (max 5 days).

LagradOst
LagradOst requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@LagradOst LagradOst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing this I found that this causes an UI bug in the library if you remove/add a favorite while in library it does not refresh. In toggleFavoriteStatus add the line MainActivity.reloadLibraryEvent(true)

@LagradOst
Copy link
Contributor

I will merge this and fix it myself along with another bottom dialog issue

@LagradOst LagradOst merged commit 97ec98b into recloudstream:master Jan 10, 2024
2 checks passed
@ghost ghost deleted the show-favorite-button branch January 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fire-light42 @LagradOst