Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: toast view to use data binding #919

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

IndusAryan
Copy link
Contributor

No description provided.

@fire-light42
Copy link
Collaborator

wdym "fix gravity bug"

@IndusAryan

This comment was marked as outdated.

@IndusAryan IndusAryan changed the title refactor: migrate toast to view bindings, fix gravity bug, upgrade gradle & ksp refactor: migrate show toast to view bindings and fix toastgravity warning Feb 7, 2024
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the behavior of the toasts to show further up, and is why setGravity is used afaik

@IndusAryan IndusAryan changed the title refactor: migrate show toast to view bindings and fix toastgravity warning refactor: toast view to use data binding Mar 12, 2024
@IndusAryan
Copy link
Contributor Author

This changes the behavior of the toasts to show further up, and is why setGravity is used afaik

reverted back the gravity, and just reduce ids to bindings

@fire-light42 fire-light42 merged commit 4817b29 into recloudstream:master Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants