-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SubScene #923
Add SubScene #923
Conversation
# Conflicts: # app/src/main/AndroidManifest.xml
Co-authored-by: Aymanbest <51868001+aymanbest@users.noreply.github.com>
deleteOnExit does not seem to work properly as of now. |
"Note that on Android, the application lifecycle does not include VM termination, so calling this method will not ensure that files are deleted. " |
Amazing Work !! |
👍 |
Splendid job. Where to select the subs from subscene? |
if you select sources in the video and scroll down the subtitle to "load from internet" it also get information from subscene, no account needed yet. |
I had to change the subtitle API to make it work with Zip files but it is backwards compatible.
Worked with @aymanbest to implement the API.