Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TV UI #950

Merged
merged 29 commits into from
Mar 9, 2024
Merged

New TV UI #950

merged 29 commits into from
Mar 9, 2024

Conversation

KingLucius
Copy link
Contributor

No description provided.

Copy link
Contributor

@Blatzar Blatzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I haven't tested the UI though.

@fire-light42
Copy link
Collaborator

Contains 2 bugs atm

  1. Episodes disappear (After playing a trailer)
  2. Remaining is fucked
    image

@KingLucius
Copy link
Contributor Author

There is another issue, the watching status button text is cutted in case of completed and plan to watch

@KingLucius
Copy link
Contributor Author

Contains 2 bugs atm

  1. Episodes disappear (After playing a trailer)
  2. Remaining is fucked
    image

First issue happens after back from Episode playing also

@KingLucius KingLucius marked this pull request as ready for review February 28, 2024 13:49
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fast code review, I need to test this in an emulator so another more in depth review might come later

@LinkofHyrule89
Copy link

Is this issue fixed in this updated UI? #755

@KingLucius
Copy link
Contributor Author

Is this issue fixed in this updated UI? #755

here lag mentioned it's intentional behavior so it's not a bug

@LinkofHyrule89
Copy link

Is this issue fixed in this updated UI? #755

here lag mentioned it's intentional behavior so it's not a bug

That doesn't make sense because it never moves to the next unwatched episode so it's clearly a bug. This needs to be reevaluated. It used to work correctly previously before the last big update. I think most people would agree it should work similar to Netflix or Crunchyroll or any other service and properly show the next unwatched episode.

@KingLucius
Copy link
Contributor Author

Is this issue fixed in this updated UI? #755

here lag mentioned it's intentional behavior so it's not a bug

That doesn't make sense because it never moves to the next unwatched episode so it's clearly a bug. This needs to be reevaluated. It used to work correctly previously before the last big update. I think most people would agree it should work similar to Netflix or Crunchyroll or any other service and properly show the next unwatched episode.

Ok let me study the details first, and working on a solution if there is one.

@Luna712
Copy link
Contributor

Luna712 commented Mar 7, 2024

👍 🚀 I really love this new UI. Good job! 🎉

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@KingLucius
Copy link
Contributor Author

👍 🚀 I really love this new UI. Good job! 🎉

Thank you so much 🎉

@KingLucius
Copy link
Contributor Author

for the
image
I prefer it to be just a text like rest of meta data.
what do you think?

@Luna712
Copy link
Contributor

Luna712 commented Mar 8, 2024

for the image I prefer it to be just a text like rest of meta data. what do you think?

I personally like it better as-is, it is easier to read and stands out more and is more inline with how a lot of other applications/sites display content ratings.

@KingLucius
Copy link
Contributor Author

I have added the "Coming soon" support & using "Episode" string in case that Season is null as the E1 is small and there is a space already

@fire-light42
Copy link
Collaborator

Do you want this merged?

@KingLucius
Copy link
Contributor Author

KingLucius commented Mar 9, 2024

Do you want this merged?

I am good with this so far, you can merge it
Thank you

@fire-light42 fire-light42 merged commit 510d11f into recloudstream:master Mar 9, 2024
2 checks passed
@KingLucius KingLucius deleted the NewResultUI branch March 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants