-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New TV UI #950
New TV UI #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I haven't tested the UI though.
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentTv.kt
Outdated
Show resolved
Hide resolved
There is another issue, the watching status button text is cutted in case of completed and plan to watch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fast code review, I need to test this in an emulator so another more in depth review might come later
app/src/main/java/com/lagradost/cloudstream3/syncproviders/AccountManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentTv.kt
Outdated
Show resolved
Hide resolved
Is this issue fixed in this updated UI? #755 |
That doesn't make sense because it never moves to the next unwatched episode so it's clearly a bug. This needs to be reevaluated. It used to work correctly previously before the last big update. I think most people would agree it should work similar to Netflix or Crunchyroll or any other service and properly show the next unwatched episode. |
Ok let me study the details first, and working on a solution if there is one. |
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentTv.kt
Outdated
Show resolved
Hide resolved
👍 🚀 I really love this new UI. Good job! 🎉 |
Thank you so much 🎉 |
I have added the "Coming soon" support & using "Episode" string in case that Season is null as the E1 is small and there is a space already |
Do you want this merged? |
I am good with this so far, you can merge it |
No description provided.