Issues with biometric authentication (or rather when it is disabled)

[Luna712]

Steps to reproduce

When I turn off biometric authentication I still get this which is meaningless if it is being turned off:

I see this everytime I open the app, even if it is not enabled at all in CloudStream:

Also this should not say "fingerprint" as there are other types of biometric authentication.

It also shows the "Logged in with" toast before you actually complete login with biometric if enabled, it should wait to show that for the login to actually be completed.

Expected behavior

...

Actual behavior

...

Cloudstream version and commit hash

4.3.1 bd69054

Android version

Android 14

Logcat

No response

Other details

No response

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• I have written a short but informative title.
• I have updated the app to pre-release version Latest.
• If related to a provider, I have checked the site and it works, but not the app.
• I will fill out all of the requested information in this form.

[Luna712]

I'm going to ping @IndusAryan here as the one who worked on biometric auth to begin with. I personally only like it to work for default account anyway since we can't have a PIN there, I don't find it necessary for other accounts and seems a bit overkill but it's fine and at least provides a bit of extra nice security, so thanks for that...

[IndusAryan]

1. the warning appearing twice + backup has been solved.

2. the toast has been removed , not needed anywasys because the prompt only appears when certain conditions are met, if there is no lock then no matter setting is on, it remains a dummy setting.

3. the logged in with $accountName wont be solved because we are not freezing any activity of the app, we are only hiding it for reasons ,otherwise app open will be very much slowed by about 4 seconds.

[Luna712]

@IndusAryan also I found another a major issue I think, adding biometric_key to nonTransferableKeys wont stop it from backing up IIRC, nonTransferableKeys has no actual affect, it was supposed to be fixed with #623 but that seems dead at this point? #744 (comment) — but I guess maybe we should just apply that fix anyway if that isn't progressing anymore?

[IndusAryan]

oh, then you should pr, even if it is not dead , it will take months

[Luna712]

oh, then you should pr, even if it is not dead , it will take months

@IndusAryan

I'll PR that specific fix within the next couple days I guess. Hopefully tomorrow.