New TV UI bug fixes

[KingLucius]

• Episode down to description closes Episodes Holder.
• Rework main buttons visibility, should fix the visibility bugs.
• Fix Episode space bug (Episode1)

[KingLucius]

@Luna712 Can you please support testing these fixes? Thanks

[Luna712]

This does fix the button visibility issues for me but I'm not sure how to test the others as I personally couldn't seem to reproduce.

[KillerDogeEmpire]

@KingLucius The fixes are great, they all work good.

[KingLucius]

Thanks guys for testing 🙏

[fire-light42]

observe does not have a determined order, so I dont like this. It just sounds like you are making the bug less likely

[KingLucius]

That's why i am checking the resume this way, i didn't find another way to do this.
I am open for suggestions though

[fire-light42]

I would move all the visibility logic into resumeWatching and make this function act as a setOnClickListener, then do the nextFocusRightId in the loadpage section. So this makes it so:

Page fills all the metadata about the thing
Movie adds the listener
Resume watching handles the visibility

But if this is too much the viewmodel should be simplified, as all the parts should be independent and support out of order eval

[fire-light42]

What you can do is making a dummy header view, that way you can have an "X AND Y" visibility, this is very common in cs3 for these things

[KingLucius]

I would move all the visibility logic into resumeWatching and make this function act as a setOnClickListener, then do the nextFocusRightId in the loadpage section. So this makes it so:

Page fills all the metadata about the thing
Movie adds the listener
Resume watching handles the visibility

But if this is too much the viewmodel should be simplified, as all the parts should be independent and support out of order eval

I got that, will rework based on that

[KingLucius]

What you can do is making a dummy header view, that way you can have an "X AND Y" visibility, this is very common in cs3 for these things

I don't understand that bro 😂 please elaborate or guide me to a code in CS i can read to get the idea as an example

[fire-light42]

I don't understand that bro 😂 please elaborate or guide me to a code in CS i can read to get the idea as an example

Well the idea is to have a view that holds many items, see for example apply_btt_holder

cloudstream/app/src/main/res/layout/bottom_selection_dialog.xml

Line 36 in 81df68e

android:id="@+id/apply_btt_holder"

Then you can change the visibility of the holder

cloudstream/app/src/main/java/com/lagradost/cloudstream3/utils/SingleSelectionHelper.kt

Line 116 in 81df68e

applyHolder.isVisible = realShowApply

But the neat thing is that it has a separate visibility from the view itself. So in this case if I wanted to toggle the visibility of apply by two bools, lets say realShowApply AND showApply then I can set the headers visibility to realShowApply and the apply buttons visibility to showApply. That way both the buttons (cancel and apply) are turned on if realShowApply is true, but the apply buttons is only visible if both realShowApply is true and showApply is true.

In your case I would group all buttons visible in one mode in one header view and turn that view on or off, but this will still keep the visibility state of each individual button.

[fire-light42]

But you can also just make a state machine, that specifies the conditions for every button given a set of paramaters, like isMovie, hasEpisodes, hasPreview, hasTrailer and update every buttons when you update this state

[KingLucius]

I handeled most of the visibility in ResumeWatching, and in Movie I check for Resume button visibility to toggle Play button visibility

[fire-light42]

I was unable to replicate the bug, @Luna712 can you check?

[Luna712]

Sure, I can test this in a couple hours

[Luna712]

This fixes all of the issues I could reproduce