Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#821): token classifier show predictions in explore view #1009

Merged
merged 12 commits into from Jan 26, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Jan 20, 2022

fix #821
This PR displays the predictions in the token classifier view and adds some visual changes that improve the visual distinction between annotated and predicted entities

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1009 (68a5a86) into master (1ab4a14) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 68a5a86 differs from pull request most recent head b1ac908. Consider uploading reports for the commit b1ac908 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   95.20%   95.22%   +0.01%     
==========================================
  Files         115      115              
  Lines        4339     4352      +13     
==========================================
+ Hits         4131     4144      +13     
  Misses        208      208              
Flag Coverage Δ
pytest 95.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/models.py 98.80% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab4a14...b1ac908. Read the comment docs.

@leiyre leiyre marked this pull request as ready for review January 25, 2022 14:05
@leiyre leiyre changed the title feat(#821): token classifier switch Prediction/annotation feat(#821): token classifier show predictions in explore view Jan 25, 2022
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to me. Just take a look since score for Predictions filters is not well framed

Screenshot 2022-01-25 at 23 57 25

@frascuchon frascuchon self-requested a review January 26, 2022 11:50
@frascuchon frascuchon merged commit aad8ad8 into master Jan 26, 2022
@frascuchon frascuchon deleted the feat/token_classifier_prediction_entities branch January 26, 2022 11:50
frascuchon pushed a commit that referenced this pull request Feb 17, 2022
* add toggle buttons

* fix typo

* toggle prediction/annotation

* show annotation and predictions in exploration

* get explore and annotate components

* entities new styles

* fix lint

* fix margin

* remove agent

* fix reset selected span

(cherry picked from commit aad8ad8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NER] Add switch Prediction/annotation
2 participants