Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Records] TextClassificationRecord does not raise error passing #1027

Closed
frascuchon opened this issue Jan 25, 2022 · 0 comments · Fixed by #1032
Closed

[Records] TextClassificationRecord does not raise error passing #1027

frascuchon opened this issue Jan 25, 2022 · 0 comments · Fixed by #1032
Assignees
@dcfidalgo
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

This code:

import rubrix as rb

rb.TextClassificationRecord("this is a multi label record", multilabel=True)

should raise some KeyError validation.

This should be a common behaviour for all client record instances
@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior client labels Jan 25, 2022
@frascuchon frascuchon added this to Backlog in Release via automation Jan 25, 2022
@dcfidalgo dcfidalgo mentioned this issue Jan 25, 2022
Merged
Release automation moved this from Backlog to Done Jan 26, 2022
dcfidalgo pushed a commit that referenced this issue Jan 26, 2022
Fix(#1027): Improve client models by reordering fields + forbidding e…
c1e32d1 
…xtra args (#1032)

* feat: introduce RootValidators + correct order

* feat: forbid extras + test
@frascuchon frascuchon moved this from Done to Release Ready in Release Jan 31, 2022
frascuchon pushed a commit that referenced this issue Jan 31, 2022
@frascuchon
fix(#1027): Improve client models by reordering fields + forbidding e…
6c1ae7f 
…xtra args (#1032)

* feat: introduce RootValidators + correct order

* feat: forbid extras + test

(cherry picked from commit c1e32d1)
@frascuchon frascuchon moved this from Release Ready to Closed in Release Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcfidalgo dcfidalgo

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(#1027): Improve client models by reordering fields + forbidding extra args argilla-io/argilla
2 participants
@frascuchon @dcfidalgo