Fix(#1027): Improve client models by reordering fields + forbidding extra args #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcfidalgo
changed the title
dcfidalgo
changed the title
dcfidalgo
added
the
type: bug
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
+ Coverage 95.19% 95.21% +0.01%
==========================================
Files 115 115
Lines 4330 4343 +13
==========================================
+ Hits 4122 4135 +13
Misses 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
frascuchon
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
You should raise your own exceptions. See here
I think we should make some effort to parse errors from pydantic validation, and make them human readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1027
With this PR the client models raise an error when extra arguments are provided. The error message is not the clearest though, but i did not find a way to modify this. @frascuchon Do you know how to customize validation error messages in pydantic?
It also fixes the order of the fields in the models. This is important when converting the records into a DataFrame/Dataset, so that when displaying a DataFrame the order of the columns is more or less meaningful.