Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Client] Clean up the rubrix namespace #1130

Closed
dcfidalgo opened this issue Feb 10, 2022 · 1 comment · Fixed by #1160
Closed

[Client] Clean up the rubrix namespace #1130

dcfidalgo opened this issue Feb 10, 2022 · 1 comment · Fixed by #1160
Assignees
@dcfidalgo
Projects
Release

Comments

@dcfidalgo
Copy link
Contributor

I think it would be nice to have a cleaner namespace when importing rubrix.
When we do import rubrix as rb in jupyter, an rb.<tab> will show you a lot of stuff since we do all kinds of imports in the init.py that are not really meant for the end-user.
@dcfidalgo dcfidalgo self-assigned this Feb 10, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Feb 10, 2022
@dvsrepo
Copy link
Member

dvsrepo commented Feb 11, 2022

+1

@dcfidalgo dcfidalgo mentioned this issue Feb 15, 2022
Merged
@dcfidalgo dcfidalgo moved this from Backlog to In progress in Release Feb 16, 2022
Release automation moved this from In progress to Ready to DEV QA Mar 7, 2022
dcfidalgo pushed a commit that referenced this issue Mar 7, 2022
feat(#1130): Cleanup rb namespace by refactoring client API (#1160)
fd2186d 
* feat: use scm's _version for __version__

* feat: introduce new user facing API

* feat: add LazyRubrixModule

* feat: implement lazy imports with deprecated future warnings

* feat: use new api module

* docs: add small info

* test: convert init tests to api tests + cleanup

* chore: add workspace assertion back

* test: adapt tests

* test: adapt test for deprecated rubrix_client

* chore: merge latest changes from master

* test: adapt tests to latest changes from master

* chore: hide configure_logging from rb namespace

* chore: set CLIENT/USER to None if init failed

* chore: use new client api

* test: adapt/cleanup tests

* chore: correct imports

* chore: cleanup imports

* test: improve coverage

* test: improve coverage

* feat: wrap api methods in Api class, introduce ACTIVE_API attribute

* test: fix tests
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Mar 8, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to DEV QA in Release Mar 8, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Mar 25, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Mar 25, 2022
frascuchon added a commit that referenced this issue Mar 25, 2022
@frascuchon
feat(#1130): cleanup rb namespace by refactoring client API (#1160)
bdf56c2
frascuchon added a commit that referenced this issue Mar 28, 2022
@frascuchon
feat(#1130): cleanup rb namespace by refactoring client API (#1160)
76272ef
frascuchon added a commit that referenced this issue Mar 28, 2022
@frascuchon
feat(#1130): cleanup rb namespace by refactoring client API (#1160)
92c1180
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this issue Mar 30, 2022
@frascuchon
feat(#1130): cleanup rb namespace by refactoring client API (#1160)
a0fdd8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcfidalgo dcfidalgo

Labels
None yet
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#1130): Cleanup rb namespace by refactoring client API argilla-io/argilla
2 participants
@dvsrepo @dcfidalgo