New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1029): improve server api logging #1148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 95.06% 95.02% -0.05%
==========================================
Files 123 122 -1
Lines 4846 4827 -19
==========================================
- Hits 4607 4587 -20
- Misses 239 240 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
* feat(logging): improve server api logging * chore: rubrix:app * chore: conditional logging configuration if module loguru not found * chore: rename logging handler * test: logging handler is configured properly * chore: better warning message
* feat(logging): improve server api logging * chore: rubrix:app * chore: conditional logging configuration if module loguru not found * chore: rename logging handler * test: logging handler is configured properly * chore: better warning message (cherry picked from commit 18efbfb)
* feat(logging): improve server api logging * chore: rubrix:app * chore: conditional logging configuration if module loguru not found * chore: rename logging handler * test: logging handler is configured properly * chore: better warning message (cherry picked from commit 18efbfb) chore(#1029): generalize logging configuration message (#1224) (cherry picked from commit c390911)
This PR improves the server api logging by using loguru. If loguru package is not installed, the "basic" logging will be used.
In future PRs we can customize or parameterize some aspects of new logging engine.
The logging traces looks like that:
Closes #1029