Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rb.init time out, replace httpx with requests, it worked #1207

Closed
HuipengXu opened this issue Feb 28, 2022 · 6 comments · Fixed by #1208
Closed

rb.init time out, replace httpx with requests, it worked #1207

HuipengXu opened this issue Feb 28, 2022 · 6 comments · Fixed by #1208
Assignees
@frascuchon
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@HuipengXu
Copy link

as above
image
image
image
@HuipengXu HuipengXu added the type: bug Indicates an unexpected problem or unintended behavior label Feb 28, 2022
@frascuchon frascuchon self-assigned this Feb 28, 2022
@frascuchon
Copy link
Member

Hello @HuipengXu

Thanks for reaching out. Could you share a bit more of information about your running environment?

@HuipengXu
Copy link
Author

rubrix[server]==0.11.0, elasticsearch-oss:7.10.2,
browser: chrome
server os: centos7
client os: win10
@frascuchon thx

@frascuchon frascuchon added this to Backlog in Release via automation Feb 28, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Feb 28, 2022
@frascuchon
Copy link
Member

Okay, If I understood, your problem is that you get a timeout error by requesting with httpx but with requests everything go fine. It's okay?

I imagine it's working the default timeout behaviour for requests library is to hang until server send the response. What timeout are you setting up? I realized that you have a low connection between server and client, it's not?

@frascuchon frascuchon mentioned this issue Feb 28, 2022
Merged
frascuchon added a commit that referenced this issue Feb 28, 2022
@frascuchon
fix(#1207): using api sdk wrapper is better (#1208)
5404b9a 
* fix(init): using api sdk wrapper is better

* Update src/rubrix/client/rubrix_client.py

Co-authored-by: David Fidalgo <david@recogn.ai>

* test: fix and add missing tests

* fix: update dataset name

Co-authored-by: David Fidalgo <david@recogn.ai>
@HuipengXu
Copy link
Author

HuipengXu commented Mar 1, 2022 •
edited

Okay, If I understood, your problem is that you get a timeout error by requesting with httpx but with requests everything go fine. It's okay?

right

I imagine it's working the default timeout behaviour for requests library is to hang until server send the response. What timeout are you setting up? I realized that you have a low connection between server and client, it's not?

I have try to set timeout 200 seconds, but it not worked

@frascuchon frascuchon moved this from Planified to Review in Release Mar 2, 2022
@frascuchon frascuchon moved this from Review to Ready to DEV QA in Release Mar 2, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Mar 3, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Mar 3, 2022
frascuchon added a commit that referenced this issue Mar 3, 2022
@frascuchon
fix(#1207): using api sdk wrapper for init (#1208)
6cf9c04 
* fix(init): using api sdk wrapper is better

* Update src/rubrix/client/rubrix_client.py

Co-authored-by: David Fidalgo <david@recogn.ai>

* test: fix and add missing tests

* fix: update dataset name

Co-authored-by: David Fidalgo <david@recogn.ai>

(cherry picked from commit 5404b9a)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 3, 2022
frascuchon added a commit that referenced this issue Mar 4, 2022
@frascuchon
fix(#1207): using api sdk wrapper for init (#1208)
2495c75 
* fix(init): using api sdk wrapper is better

* Update src/rubrix/client/rubrix_client.py

Co-authored-by: David Fidalgo <david@recogn.ai>

* test: fix and add missing tests

* fix: update dataset name

Co-authored-by: David Fidalgo <david@recogn.ai>

(cherry picked from commit 5404b9a)
@dvsrepo
Copy link
Member

dvsrepo commented Mar 25, 2022

Hi @HuipengXu, did you manage to get this work?

cc @frascuchon

@HuipengXu
Copy link
Author

@dvsrepo yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(init): using api sdk wrapper is better argilla-io/argilla
3 participants
@dvsrepo @frascuchon @HuipengXu