fix(init): using api sdk wrapper is better #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcfidalgo
previously approved these changes
Feb 28, 2022
Co-authored-by: David Fidalgo <david@recogn.ai>
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
+ Coverage 95.12% 95.19% +0.07%
==========================================
Files 124 124
Lines 5024 5039 +15
==========================================
+ Hits 4779 4797 +18
+ Misses 245 242 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dcfidalgo
approved these changes
Feb 28, 2022
frascuchon
added a commit
that referenced
this pull request
Mar 3, 2022
* fix(init): using api sdk wrapper is better * Update src/rubrix/client/rubrix_client.py Co-authored-by: David Fidalgo <david@recogn.ai> * test: fix and add missing tests * fix: update dataset name Co-authored-by: David Fidalgo <david@recogn.ai> (cherry picked from commit 5404b9a)
frascuchon
added a commit
that referenced
this pull request
Mar 4, 2022
* fix(init): using api sdk wrapper is better * Update src/rubrix/client/rubrix_client.py Co-authored-by: David Fidalgo <david@recogn.ai> * test: fix and add missing tests * fix: update dataset name Co-authored-by: David Fidalgo <david@recogn.ai> (cherry picked from commit 5404b9a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the client initialization and use the sdk api wrapper. This normalizes the use of timeout in requests and the error handler in responses.
Closes #1207