Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#950): using record search_keywords for highlighting #1235

Merged
merged 5 commits into from Mar 16, 2022
Merged

feat(#950): using record search_keywords for highlighting #1235

merged 5 commits into from Mar 16, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Mar 8, 2022 •
edited

TODO

  • Text classification
  • Text2text
  • [ ] Bold highlight text

Close #950

@frascuchon frascuchon force-pushed the feat/align-app-highlight-with-search-keywords branch from 995e7df to 829dc89 Compare March 8, 2022 16:53
@frascuchon frascuchon marked this pull request as draft March 8, 2022 17:03
@frascuchon frascuchon force-pushed the feat/align-app-highlight-with-search-keywords branch from b2f8fca to 79a149e Compare March 9, 2022 09:21
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1235 (ca3b109) into master (07b895d) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
- Coverage   94.84%   94.67%   -0.18%     
==========================================
  Files         127      127              
  Lines        5449     5444       -5     
==========================================
- Hits         5168     5154      -14     
- Misses        281      290       +9
Flag Coverage Δ
pytest 94.67% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/tasks/commons/dao/dao.py 97.93% <ø> (ø)
src/rubrix/server/commons/es_helpers.py 82.19% <0.00%> (-4.24%) ⬇️
src/rubrix/server/tasks/text2text/api/model.py 98.43% <0.00%> (-0.20%) ⬇️
...rix/server/tasks/token_classification/api/model.py 98.18% <0.00%> (-0.10%) ⬇️
...brix/server/tasks/text_classification/api/model.py 99.41% <0.00%> (-0.03%) ⬇️
...ks/text_classification/service/labeling_service.py 99.20% <0.00%> (ø)
src/rubrix/server/tasks/commons/api/model.py 96.35% <0.00%> (+0.05%) ⬆️
src/rubrix/server/tasks/search/model.py 100.00% <0.00%> (+4.34%) ⬆️
src/rubrix/server/tasks/search/query_builder.py 83.63% <0.00%> (+9.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6899272...ca3b109. Read the comment docs.

@frascuchon frascuchon marked this pull request as ready for review March 11, 2022 11:17
@frascuchon frascuchon merged commit 9e11933 into master Mar 16, 2022
@frascuchon frascuchon deleted the feat/align-app-highlight-with-search-keywords branch March 16, 2022 09:28
frascuchon added a commit that referenced this pull request Mar 25, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
184e1d0 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)
frascuchon pushed a commit that referenced this pull request Mar 25, 2022
@leiyre
chore(#1235): fix highlight function name in explain (#1316)
41b3321 
Closes #1315
frascuchon added a commit that referenced this pull request Mar 25, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
c883345 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
frascuchon added a commit that referenced this pull request Mar 28, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
9708119 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
frascuchon added a commit that referenced this pull request Mar 28, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
5d55dee 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
frascuchon added a commit that referenced this pull request Mar 30, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
47616bf 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frascuchon frascuchon

@leiyre leiyre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search] Enable results highlighting for textual fields
2 participants
@frascuchon @leiyre