Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1119): Users without personal datasets #1282

Merged
merged 25 commits into from Mar 25, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Mar 21, 2022

closes #1119

This PR changes workspace management, workspace is now a filtrable field in datasets list table

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1282 (bde9345) into master (a3b0552) will increase coverage by 0.37%.
The diff coverage is 85.50%.

❗ Current head bde9345 differs from pull request most recent head bf281b1. Consider uploading reports for the commit bf281b1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1282      +/-   ##
==========================================
+ Coverage   94.06%   94.43%   +0.37%     
==========================================
  Files         129      127       -2     
  Lines        5831     5591     -240     
==========================================
- Hits         5485     5280     -205     
+ Misses        346      311      -35     
Flag Coverage Δ
pytest 94.43% <85.50%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/models.py 89.60% <0.00%> (-8.92%) ⬇️
src/rubrix/server/datasets/api.py 100.00% <ø> (ø)
src/rubrix/server/datasets/service.py 98.71% <ø> (+1.01%) ⬆️
src/rubrix/client/datasets.py 95.46% <50.00%> (-0.45%) ⬇️
src/rubrix/server/commons/es_wrapper.py 88.46% <50.00%> (+0.31%) ⬆️
src/rubrix/server/datasets/dao.py 97.89% <50.00%> (+1.81%) ⬆️
src/rubrix/client/api.py 94.58% <100.00%> (+0.02%) ⬆️
...rc/rubrix/labeling/text_classification/__init__.py 100.00% <100.00%> (ø)
...ubrix/labeling/text_classification/label_models.py 100.00% <100.00%> (ø)
src/rubrix/labeling/text_classification/rule.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b0552...bf281b1. Read the comment docs.

@frascuchon
Copy link
Member

Applied filters are not visibles as url query params. Following image shows a dataset list where recognai filter is applied from breadcrumb click and francisco is applied by clicking in filter selector.

Screenshot 2022-03-22 at 16 59 54

The resulting url contains only the first one.

Screenshot 2022-03-22 at 17 00 01

Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments above

@dcfidalgo
Copy link
Contributor

@leiyre I pushed a small commit in which I updated the text when the dataset list is empty. Just to let you know.

@frascuchon frascuchon self-requested a review March 24, 2022 17:24
@frascuchon
Copy link
Member

@leiyre please, resolve conflicts locally. A lot of changes are applied in user.vue and I cannot do the conflicts resolution by myself

leiyre and others added 3 commits March 25, 2022 09:48
@frascuchon frascuchon merged commit 068e4be into master Mar 25, 2022
@frascuchon frascuchon deleted the feat/workspace_filtrable branch March 25, 2022 10:20
frascuchon pushed a commit that referenced this pull request Mar 25, 2022
frascuchon pushed a commit that referenced this pull request Mar 25, 2022
(cherry picked from commit 068e4be)

chore(#1119): fix user dropdown styles (#1318)

Closes #1317
This PR fixes alignment and width

(cherry picked from commit eb70459)
frascuchon pushed a commit that referenced this pull request Mar 28, 2022
(cherry picked from commit 068e4be)

chore(#1119): fix user dropdown styles (#1318)

Closes #1317
This PR fixes alignment and width

(cherry picked from commit eb70459)
frascuchon pushed a commit that referenced this pull request Mar 28, 2022
(cherry picked from commit 068e4be)

chore(#1119): fix user dropdown styles (#1318)

Closes #1317
This PR fixes alignment and width

(cherry picked from commit eb70459)

fix(#1323): align text and icon in dataset name (#1324)

Closes #1323

(cherry picked from commit 158fcad)
frascuchon pushed a commit that referenced this pull request Mar 30, 2022
(cherry picked from commit 068e4be)

chore(#1119): fix user dropdown styles (#1318)

Closes #1317
This PR fixes alignment and width

(cherry picked from commit eb70459)

fix(#1323): align text and icon in dataset name (#1324)

Closes #1323

(cherry picked from commit 158fcad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workspaces] Users without personal datasets
3 participants