Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPLAIN] Text highlight in explain mode doesn't work #1315

Closed
leiyre opened this issue Mar 25, 2022 · 0 comments · Fixed by #1316
Closed

[EXPLAIN] Text highlight in explain mode doesn't work #1315

leiyre opened this issue Mar 25, 2022 · 0 comments · Fixed by #1316
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior

Comments

@leiyre
Copy link
Member

leiyre commented Mar 25, 2022

error page is shown when accessing explain records
@leiyre leiyre added type: bug Indicates an unexpected problem or unintended behavior text-classification labels Mar 25, 2022
@leiyre leiyre self-assigned this Mar 25, 2022
leiyre added a commit that referenced this issue Mar 25, 2022
@leiyre
fix(#1315): fix highlight function name in explain
03cbec6 
fixes #1315
@leiyre leiyre mentioned this issue Mar 25, 2022
Merged
frascuchon pushed a commit that referenced this issue Mar 25, 2022
@leiyre
chore(#1235): fix highlight function name in explain (#1316)
41b3321 
Closes #1315
frascuchon added a commit that referenced this issue Mar 25, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
c883345 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
frascuchon added a commit that referenced this issue Mar 28, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
9708119 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
frascuchon added a commit that referenced this issue Mar 28, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
5d55dee 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
frascuchon added a commit that referenced this issue Mar 30, 2022
@frascuchon
feat(#950): using record search_keywords for highlighting (#1235)
47616bf 
* feat(#950): using record search_keywords for highlighting

* feat(highlight): keywords for text-classification

* feat(highlight): keywords for text2text

* test: update snapshots

* fix: compute search keywords for old datasets, based on 'words' field

(cherry picked from commit 9e11933)

fix(#950):  improve highlight for multi terms searches (#1278)

* fix(hightlight): merge adjacent terms

* refactor: apply multi-keyword search in text

* feat: merge highlighted phrases

* feat: parse keywords as entire words

* fix(highlight): include hightlight info at visual token level

* chore: lint

* fix: escape html before apply highligh span

* fix calc whitespace for highlighted entities

* fix: parse middle highlighted tokens

* refactor: highligh on inputs

* test: update tests

Co-authored-by: LeireA <leire@recogn.ai>
(cherry picked from commit 3a32334)

chore(#1235): fix highlight function name in explain (#1316)

Closes #1315

(cherry picked from commit 41b3321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1315): fix highlight function name in explain argilla-io/argilla
1 participant
@leiyre