fix(#1315): fix highlight function name in explain #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
approved these changes
Mar 25, 2022
frascuchon
added a commit
that referenced
this pull request
Mar 25, 2022
* feat(#950): using record search_keywords for highlighting * feat(highlight): keywords for text-classification * feat(highlight): keywords for text2text * test: update snapshots * fix: compute search keywords for old datasets, based on 'words' field (cherry picked from commit 9e11933) fix(#950): improve highlight for multi terms searches (#1278) * fix(hightlight): merge adjacent terms * refactor: apply multi-keyword search in text * feat: merge highlighted phrases * feat: parse keywords as entire words * fix(highlight): include hightlight info at visual token level * chore: lint * fix: escape html before apply highligh span * fix calc whitespace for highlighted entities * fix: parse middle highlighted tokens * refactor: highligh on inputs * test: update tests Co-authored-by: LeireA <leire@recogn.ai> (cherry picked from commit 3a32334) chore(#1235): fix highlight function name in explain (#1316) Closes #1315 (cherry picked from commit 41b3321)
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
* feat(#950): using record search_keywords for highlighting * feat(highlight): keywords for text-classification * feat(highlight): keywords for text2text * test: update snapshots * fix: compute search keywords for old datasets, based on 'words' field (cherry picked from commit 9e11933) fix(#950): improve highlight for multi terms searches (#1278) * fix(hightlight): merge adjacent terms * refactor: apply multi-keyword search in text * feat: merge highlighted phrases * feat: parse keywords as entire words * fix(highlight): include hightlight info at visual token level * chore: lint * fix: escape html before apply highligh span * fix calc whitespace for highlighted entities * fix: parse middle highlighted tokens * refactor: highligh on inputs * test: update tests Co-authored-by: LeireA <leire@recogn.ai> (cherry picked from commit 3a32334) chore(#1235): fix highlight function name in explain (#1316) Closes #1315 (cherry picked from commit 41b3321)
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
* feat(#950): using record search_keywords for highlighting * feat(highlight): keywords for text-classification * feat(highlight): keywords for text2text * test: update snapshots * fix: compute search keywords for old datasets, based on 'words' field (cherry picked from commit 9e11933) fix(#950): improve highlight for multi terms searches (#1278) * fix(hightlight): merge adjacent terms * refactor: apply multi-keyword search in text * feat: merge highlighted phrases * feat: parse keywords as entire words * fix(highlight): include hightlight info at visual token level * chore: lint * fix: escape html before apply highligh span * fix calc whitespace for highlighted entities * fix: parse middle highlighted tokens * refactor: highligh on inputs * test: update tests Co-authored-by: LeireA <leire@recogn.ai> (cherry picked from commit 3a32334) chore(#1235): fix highlight function name in explain (#1316) Closes #1315 (cherry picked from commit 41b3321)
frascuchon
added a commit
that referenced
this pull request
Mar 30, 2022
* feat(#950): using record search_keywords for highlighting * feat(highlight): keywords for text-classification * feat(highlight): keywords for text2text * test: update snapshots * fix: compute search keywords for old datasets, based on 'words' field (cherry picked from commit 9e11933) fix(#950): improve highlight for multi terms searches (#1278) * fix(hightlight): merge adjacent terms * refactor: apply multi-keyword search in text * feat: merge highlighted phrases * feat: parse keywords as entire words * fix(highlight): include hightlight info at visual token level * chore: lint * fix: escape html before apply highligh span * fix calc whitespace for highlighted entities * fix: parse middle highlighted tokens * refactor: highligh on inputs * test: update tests Co-authored-by: LeireA <leire@recogn.ai> (cherry picked from commit 3a32334) chore(#1235): fix highlight function name in explain (#1316) Closes #1315 (cherry picked from commit 41b3321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1315