New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ner): build entities from tags #1327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse entities from `U` tags - Assume `I` or `L` as start token if not found before
frascuchon
added
the
type: bug
Indicates an unexpected problem or unintended behavior
label
Mar 28, 2022
dvsrepo
approved these changes
Mar 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
=======================================
Coverage 94.21% 94.22%
=======================================
Files 129 129
Lines 5841 5851 +10
=======================================
+ Hits 5503 5513 +10
Misses 338 338
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
frascuchon
added a commit
that referenced
this pull request
Mar 28, 2022
…#1234) * fix: optional search_keywords * feat(datasets): simplify load flow from hf datasetswith no rb format * feat(token-class): allow create record with tags list * feat: mapping shortcut * chore: adjust datasets mappings * chore: better messages * feat: parse shorcut for text2text * test: skip dataset * refactor: build text from tokens if possible for NER records * test: fix tests (cherry picked from commit a64476b) fix(ner): build entities from tags (#1327) * fix(ner): parse ner tags - Parse entities from `U` tags - Assume `I` or `L` as start token if not found before * test: add missing tests (cherry picked from commit aac62fc)
frascuchon
added a commit
that referenced
this pull request
Mar 30, 2022
…#1234) * fix: optional search_keywords * feat(datasets): simplify load flow from hf datasetswith no rb format * feat(token-class): allow create record with tags list * feat: mapping shortcut * chore: adjust datasets mappings * chore: better messages * feat: parse shorcut for text2text * test: skip dataset * refactor: build text from tokens if possible for NER records * test: fix tests (cherry picked from commit a64476b) fix(ner): build entities from tags (#1327) * fix(ner): parse ner tags - Parse entities from `U` tags - Assume `I` or `L` as start token if not found before * test: add missing tests (cherry picked from commit aac62fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing found errors:
U
tags.['I-LOC', 'I-LOC', 'I-LOC', 'O', 'O', 'O']