Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ner): build entities from tags #1327

Merged
merged 2 commits into from Mar 28, 2022

Conversation

frascuchon
Copy link
Member

Fixing found errors:

  • Parse entities from U tags.
  • Assume missing start tags to build entities: ['I-LOC', 'I-LOC', 'I-LOC', 'O', 'O', 'O']

- Parse entities from `U` tags
- Assume `I` or `L` as start token if not found before
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Mar 28, 2022
@frascuchon frascuchon self-assigned this Mar 28, 2022
@frascuchon frascuchon added this to In progress in Release via automation Mar 28, 2022
Release automation moved this from In progress to Review OK Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1327 (60c3bd6) into master (008d22a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   94.21%   94.22%           
=======================================
  Files         129      129           
  Lines        5841     5851   +10     
=======================================
+ Hits         5503     5513   +10     
  Misses        338      338           
Flag Coverage Δ
pytest 94.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/models.py 98.59% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395e6ff...60c3bd6. Read the comment docs.

@frascuchon frascuchon merged commit aac62fc into master Mar 28, 2022
Release automation moved this from Review OK to Ready to DEV QA Mar 28, 2022
@frascuchon frascuchon deleted the bugfixes/build-entities-from-tags branch March 28, 2022 13:54
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Mar 28, 2022
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this pull request Mar 28, 2022
…#1234)

* fix: optional search_keywords

* feat(datasets): simplify load flow from hf datasetswith no rb format

* feat(token-class): allow create record with tags list

* feat: mapping shortcut

* chore: adjust datasets mappings

* chore: better messages

* feat: parse shorcut for text2text

* test: skip dataset

* refactor: build text from tokens if possible for NER records

* test: fix tests

(cherry picked from commit a64476b)

fix(ner): build entities from tags (#1327)

* fix(ner): parse ner tags

- Parse entities from `U` tags
- Assume `I` or `L` as start token if not found before

* test: add missing tests

(cherry picked from commit aac62fc)
frascuchon added a commit that referenced this pull request Mar 30, 2022
…#1234)

* fix: optional search_keywords

* feat(datasets): simplify load flow from hf datasetswith no rb format

* feat(token-class): allow create record with tags list

* feat: mapping shortcut

* chore: adjust datasets mappings

* chore: better messages

* feat: parse shorcut for text2text

* test: skip dataset

* refactor: build text from tokens if possible for NER records

* test: fix tests

(cherry picked from commit a64476b)

fix(ner): build entities from tags (#1327)

* fix(ner): parse ner tags

- Parse entities from `U` tags
- Assume `I` or `L` as start token if not found before

* test: add missing tests

(cherry picked from commit aac62fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants