Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Installation] Exclude loguru from server dependences #1331

Closed
frascuchon opened this issue Mar 28, 2022 · 0 comments · Fixed by #1372
Closed

[Installation] Exclude loguru from server dependences #1331

frascuchon opened this issue Mar 28, 2022 · 0 comments · Fixed by #1372
Assignees
@frascuchon @dcfidalgo
Labels
area: server Indicates that an issue or pull request is related to the server type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

Since loguru is an optional dep, should not be installed as default when installing rubrix server.

See #1305
@frascuchon frascuchon added the type: enhancement Indicates new feature requests label Mar 28, 2022
@frascuchon frascuchon self-assigned this Mar 28, 2022
@frascuchon frascuchon added this to Backlog in Release via automation Mar 28, 2022
@frascuchon frascuchon mentioned this issue Mar 28, 2022
Closed
@frascuchon frascuchon moved this from Backlog to Planified in Release Mar 29, 2022
@frascuchon frascuchon added area: server Indicates that an issue or pull request is related to the server client labels Mar 31, 2022
@dcfidalgo dcfidalgo mentioned this issue Apr 1, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release Apr 3, 2022
Release automation moved this from In progress to Ready to DEV QA Apr 4, 2022
frascuchon pushed a commit that referenced this issue Apr 11, 2022
@frascuchon
setup: remove loguru dependency (#1372)
1f7c1a2 
Closes #1331
Closes #1305

(cherry picked from commit 7ce45b8)
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Apr 11, 2022
@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior and removed type: enhancement Indicates new feature requests labels Apr 11, 2022
frascuchon pushed a commit that referenced this issue Apr 11, 2022
@frascuchon
fix(install): remove loguru dependency (#1372)
9e52414 
Closes #1331
Closes #1305

(cherry picked from commit 7ce45b8)

- refactor: avoid a lot of warning related to advanded_query_dsl parsing
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

@dcfidalgo dcfidalgo

Labels
area: server Indicates that an issue or pull request is related to the server type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove loguru dependency argilla-io/argilla
2 participants
@frascuchon @dcfidalgo