Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): store single-label rules with a comp. format for old versions #1334

Merged
merged 1 commit into from Mar 29, 2022

Conversation

frascuchon
Copy link
Member

Changes here allow read rules with older rubrix versions

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1334 (feb98f0) into master (aac62fc) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
- Coverage   94.22%   94.21%   -0.01%     
==========================================
  Files         129      129              
  Lines        5851     5860       +9     
==========================================
+ Hits         5513     5521       +8     
- Misses        338      339       +1     
Flag Coverage Δ
pytest 94.21% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/tasks/text_classification/service/service.py 96.62% <88.88%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4524339...feb98f0. Read the comment docs.

@frascuchon frascuchon merged commit d5044df into master Mar 29, 2022
@frascuchon frascuchon deleted the bugfixes/backward-comp-rules branch March 29, 2022 11:51
frascuchon added a commit that referenced this pull request Mar 29, 2022
frascuchon added a commit that referenced this pull request Mar 29, 2022
frascuchon added a commit that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant