Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#961): Rules metrics in sidebar #1377

Merged
merged 11 commits into from Apr 7, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Apr 4, 2022

closes #961

This PR includes rule metrics in sidebar and some changes in sidebar styles and logic

@leiyre leiyre requested a review from frascuchon April 4, 2022 11:32
@leiyre leiyre requested a review from frascuchon April 6, 2022 12:10
@frascuchon
Copy link
Member

why there are so many affected files? Is there a way to centralize styles config and avoid all CSS changes?

cc @leiyre

@leiyre
Copy link
Member Author

leiyre commented Apr 7, 2022

@frascuchon there are so many changes because I centralised some sidebar settings as a variable to avoid so many changes in the future

@frascuchon frascuchon merged commit a26a910 into master Apr 7, 2022
@frascuchon frascuchon deleted the feat/overall_rule_metrics_sidebar branch April 7, 2022 20:42
frascuchon pushed a commit that referenced this pull request May 4, 2022
(cherry picked from commit a26a910)

- include sidebar metrics animation (#1408)
(cherry picked from commit a775889)
frascuchon pushed a commit that referenced this pull request May 10, 2022
(cherry picked from commit a26a910)

- include sidebar metrics animation (#1408)
(cherry picked from commit a775889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Weak supervision] Rules numbers by label
2 participants